fix(Button): fix accessibility issues - #6870
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 5dd0018 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
philibea
approved these changes
Sep 3, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## button-fix #6870 +/- ##
===========================================
Coverage 90.97% 90.97%
===========================================
Files 572 572
Lines 10526 10526
Branches 3797 3819 +22
===========================================
Hits 9576 9576
Misses 950 950
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
jsulpis
force-pushed
the
button-accessibility
branch
from
September 4, 2026 07:30
1110a84 to
a2ede52
Compare
jsulpis
force-pushed
the
button-accessibility
branch
from
September 4, 2026 11:45
a2ede52 to
5dd0018
Compare
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Button accessibility issues. One remaining issue is caused by the colors from the base theme which has a bad contrast.